-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: OpenDNSSEC 2.0, OpenDNSSEC 1.4.10
-
Fix Version/s: None
-
Component/s: Signer
-
Labels:None
We noticed on a staging environment using 1.4.9 that ods-signer was receiving
a notify message but the zone transfer was not triggered.
After some investigation we pinpointed the issue on commit 88bcdcf5. Before 88bcdcf5 [Make handling of notifies more consistent] notifies where forwarded for zone transfer when the ancount was zero, but after the refactoring the relevant code was moved inside the `if (count)`
block.
I have prepared and attached a patch that works for me.
1.4.9 Is the first affected version.
Before: Apr 11 18:07:57 server ods-signerd: [socket] incoming udp message Apr 11 18:07:57 server ods-signerd: [query] tsig NOT PRESENT Apr 11 18:07:57 server ods-signerd: [query] incoming notify for zone example.com Apr 11 18:07:57 server ods-signerd: [acl] match 1.2.3.4 Apr 11 18:07:57 server ods-signerd: [socket] query processed qstate=0 Apr 11 18:07:57 server ods-signerd: [socket] sending 37 bytes over udp Apr 11 18:07:57 server ods-signerd: [dnshandler] netio dispatch With patch: Apr 11 19:27:07 server ods-signerd: [socket] incoming udp message Apr 11 19:27:07 server ods-signerd: [query] tsig NOT PRESENT Apr 11 19:27:07 server ods-signerd: [query] incoming notify for zone example.com Apr 11 19:27:07 server ods-signerd: [acl] match 1.2.3.4 Apr 11 19:27:07 server ods-signerd: [query] forward notify for zone example.com from client 83.212.169.167 Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com sets timer timeout now Apr 11 19:27:07 server ods-signerd: [dnshandler] forwarded notify: 0 bytes sent Apr 11 19:27:07 server ods-signerd: [socket] query processed qstate=0 Apr 11 19:27:07 server ods-signerd: [socket] sending 37 bytes over udp Apr 11 19:27:07 server ods-signerd: [dnshandler] netio dispatch Apr 11 19:27:07 server ods-signerd: [xfrhandler] read forwarded dns packet: 0 bytes received Apr 11 19:27:07 server ods-signerd: [xfrhandler] netio dispatch Apr 11 19:27:07 server ods-signerd: [netio] dispatch timeout event without checking for other events Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com timeout Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com make request [tcp round 0 master 83.212.169.167:0] Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com open tcp connection to 83.212.169.167 Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com request axfr to 1.2.3.4 Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com sending tcp query id=26862 Apr 11 19:27:07 server ods-signerd: [xfrhandler] netio dispatch Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com event tcp write Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com done writing, get ready for reading Apr 11 19:27:07 server ods-signerd: [xfrhandler] netio dispatch Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com event tcp read Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com got update indicating current serial 2016041122 from 83.212.169.167 Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com sets timer timeout refresh 10800 Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com wait refresh time Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com xfr packet parsed (res 5) Apr 11 19:27:07 server ods-signerd: [xfrd] tcp read xfr: release connection Apr 11 19:27:07 server ods-signerd: [xfrd] zone example.com release tcp connection to 83.212.169.167 Apr 11 19:27:07 server ods-signerd: [xfrhandler] netio dispatch
- is cloned by
-
-
- Resolved
-