Uploaded image for project: 'OpenDNSSEC'
  1. OpenDNSSEC
  2. OPENDNSSEC-791

Duplication and divergence of conf.xml configuration parsing.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: future
    • Component/s: None
    • Labels:
      None

      Description

      The source files signer/src/parser/confparser.[ch] and enforcer/src/parser/confparser.[ch] are much diverged, but should parse the exact same kind of configuration file. Hence they should work the same. The have common origins and should not have diverged. The seemingly necessity of divergence, to create different datastructures for enforcer and signer is actually a design flaw, configuration parsing should be independent of the application implementation.

      The source files libhsm/src/bin/confparser.c and libhsm/checks/confparser.c contain a subset of the earlier source files, needed because the utilities in which they are used also need access to the configuration parsing, but cannot include all configuration parsing, just because they include also data structures of enforcer or signer, which cannot be the case here as it would draw in almost all application code.

      For libhsm/src/bin/confparser.c and libhsm/checks/confparser.c the symbol parse_conf_repositories() is duplicate. For the origin source files, the following symbols are duplicated: parse_file_check(), parse_conf_string(), parse_conf_zonelist_filename(), parse_conf_log_filename(), parse_conf_pid_filename(), parse_conf_clisock_filename(), parse_conf_working_dir(), parse_conf_username(), parse_conf_group(), parse_conf_chroot(), parse_conf_use_syslog(), parse_conf_verbosity(), parse_conf_worker_threads().

      It might be better to consider re-working the configuration parsing alltogether.

      Note that duplication into libhsm/src/bin/confparser.c and libhsm/checks/confparser.c also lead to a number of extern declarations of the method in them, because of the lack of header file.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              hodar Hoda Rohani
              Reporter:
              berry Berry van Halderen
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: