Uploaded image for project: 'OpenDNSSEC'
  1. OpenDNSSEC
  2. OPENDNSSEC-345

Remove the usage of pkill, killall or /bin/false to HUP enforcer daemon in ods-ksmutil

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.3.10, 1.4.0b1
    • Fix Version/s: 1.3.11, 1.4.0b2
    • Component/s: Enforcer
    • Labels:
      None

      Description

      At configuration time it will search for pkill or killall to be used in ods-ksmutil (any maybe other places) to send a HUP to Enforcer daemon. If no program is found /bin/false is used.

      This is kinda REALLY bad, if the programs are not available no warning is given and /bin/false is used and then ods-ksmutil is not able to send HUP which in turn kinda breaks the setup.

      Another thing is that killall (regardless of options) will actually kill all processes on some platforms and in turn kill the system.

      There is also the possibility that you run 2 or more Enforcers on the same system and since pkill will send HUP to all processes that it matches we would send unnecessary HUP's.

      We should change this to read the pid file and use kill(2) to send a HUP signal.

        Attachments

          Activity

            People

            Assignee:
            sion Siôn Lloyd
            Reporter:
            jerry Jerry Lundström
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: