Uploaded image for project: 'OpenDNSSEC TRAC Import'
  1. OpenDNSSEC TRAC Import
  2. ODSTRACIMPORT-74

acx_sqlite3.m4 requires sqlite3 command

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: trunk
    • Fix Version/s: None
    • Component/s: SoftHSM
    • Labels:
      None

      Description

      Hi,

      configure script requires (and AC_SUBSTs) sqlite3 command, which is then unused anywhere:

      $ grep -r SQLITE3 . | grep -Ev "(Makefile.in|configure(.ac)?|acx_sqlite3.m4):"
      ./config.h.in:#undef HAVE_LIBSQLITE3
      ./config.h.in:#undef HAVE_SQLITE3_H
      ./src/lib/Makefile.am: @SQLITE3_INCLUDES@
      ./src/lib/Makefile.am:libsofthsm_la_LIBADD = @BOTAN_LIBS@ @SQLITE3_LIBS@ @YIELD_LIB@
      ./src/bin/Makefile.am: @SQLITE3_INCLUDES@

      While it's not a problem to add sqlite3 as build-time dependency, I usually try to keep dependencies down as much as possible.

      Ondrej

        Attachments

          Activity

            People

            Assignee:
            rickard Rickard Bellgrim
            Reporter:
            oerdnj Ondřej Surý
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: